This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, fortran, pr77785, v2] [Coarray] ICE in gfc_get_caf_token_offset, at fortran/trans-expr.c:1990
- From: Andre Vehreschild <vehre at gmx dot de>
- To: Janus Weil <janus at gcc dot gnu dot org>
- Cc: GCC-Patches-ML <gcc-patches at gcc dot gnu dot org>, GCC-Fortran-ML <fortran at gcc dot gnu dot org>
- Date: Mon, 12 Dec 2016 18:44:36 +0100
- Subject: Re: [PATCH, fortran, pr77785, v2] [Coarray] ICE in gfc_get_caf_token_offset, at fortran/trans-expr.c:1990
- Authentication-results: sourceware.org; auth=none
- References: <20161212125614.24ca3ca5@vepi2> <CAKwh3qibwNnBNOY+gVG24-qCHFtLf+CVeR4eoeTMH9j1iPyygA@mail.gmail.com>
Hi Janus,
all the sanitizer issues I fixed occur during compiling the testsuite. So I
would say, that when with the patch these errors do not occur anymore while
processing the testsuite, then those are tested for, right?
- Andre
On Mon, 12 Dec 2016 13:37:43 +0100
Janus Weil <janus@gcc.gnu.org> wrote:
> Hi Andre,
>
> > the attached patch corrects reporting of "Sorry, unimplemented yet" for
> > allocatable and pointer components in polymorphic objects (BT_CLASS) thus
> > fixing two ICEs reported in the PR.
> >
> > The next chunk fixes an ICE when the declaration containing the token
> > information is of type POINTER or REFERENCE.
> >
> > Bootstraps and regtests ok on x86_64-linux/f23. Ok for trunk?
>
> the resolve.c hunk is certainly ok. The trans-array.c part looks
> reasonable as well, but I wonder if it is actually covered by any of
> your test cases? Since they are all compile-only, with errors being
> thrown at resolution stage, do they even get to the translation stage?
>
> Cheers,
> Janus
--
Andre Vehreschild * Email: vehre ad gmx dot de