This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR78027


On Mon, Dec 12, 2016 at 09:29:44AM -0700, Jeff Law wrote:
> >>>2016-12-08  Cesar Philippidis  <cesar@codesourcery.com>
> >>>
> >>>    PR fortran/78027
> >>>
> >>>    gcc/
> >>>    * ipa-icf.c (sem_function::parse): Don't process functions with
> >>>    oacc decl attributes, as they may be OpenACC routines.
> >>>
> >>>    gcc/testsuite/
> >>>    * c-c++-common/goacc/acc-icf.c: New test.
> >>>    * gfortran.dg/goacc/pr78027.f90: New test.
> >>This follows the same approach as we do for openmp.  This is fine for
> >>the trunk.
> >
> >Is this also OK for gcc-6?
> Your call -- I don't think folks are really using OpenACC much in gcc-6, but
> if you think it's worth the time, go ahead.

As Alex noted, the patch looks wrong, there should be "omp declare target"
attribute, which isn't specific to OpenMP only, but covers all the
offloading fns.  I have on my todo list to look at it.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]