Re: [0/67] Add wrapper classes for machine_modes

[Sandra Loosemore <sandra at codesourcery dot com>]

On 12/09/2016 05:48 AM, Richard Sandiford wrote:
> This series includes most of the changes in group C from:
>
>      https://gcc.gnu.org/ml/gcc/2016-11/msg00033.html
>
> The idea is to add wrapper classes around machine_mode_enum
> for specific groups of modes, such as scalar integers, scalar floats,
> complex values, etc.  [snip]
>
> Sorry that this is so late, been distracted by other things.  Even if
> we're too far into stage 3 for SVE itself to go in, I was hoping this
> part (which was kind-of posted during stage 1) could go in independently.

I have no power to approve or reject this patch series....  but, just as 
an engineering process matter, I don't think this belongs in Stage 3: 
"During this two-month period, the only (non-documentation) changes that 
may be made are changes that fix bugs or new ports which do not require 
changes to other parts of the compiler. New functionality may not be 
introduced during this period."

I don't think a 67-part patch series whose existence was revealed only 3 
days before the close of stage 1 and were not actually posted qualifies 
for the "Patches posted early enough during Stage 1 and not yet fully 
reviewed may still get in early in Stage 3." exception either.

Richard, I appreciate that you are very methodical in your work and 
careful to test it thoroughly.  But IMO a patch series this invasive is 
likely to disrupt other people who are trying to fix bugs at this time 
to improve the 7.0 release quality.

-Sandra