This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] whitespace fix for p9-dimode tests
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, dje dot gcc at gmail dot com
- Date: Thu, 8 Dec 2016 20:55:14 -0600
- Subject: Re: [PATCH, rs6000] whitespace fix for p9-dimode tests
- Authentication-results: sourceware.org; auth=none
- References: <1481213922.13393.31.camel@brimstone.rchland.ibm.com>
Hello,
On Thu, Dec 08, 2016 at 10:18:42AM -0600, Will Schmidt wrote:
> I am seeing some failures in the p9-dimode tests. This appears to
> be due to the scan-assembler strings matching comment portions of the
> generated assembly, versus the actual generated assembly. In
> particular, the dg-final directive { scan-assembler-not "ld"}
> is matching the "ld" as seen in the string
> # 19 "/home/willschm/gcc/gcc-mainline-vec_fold/..."
>
> This is resolved by adding a leading whitespace regex string "\[ \t\]"
> as seen in other tests.
That works; a more future-proof way is writing it as
/* { dg-final { scan-assembler-not {\mld\M} } } */
which will also not match a future "ldlol" instruction (\m \M are like
\< \> in some other regular expression dialects; see
https://www.tcl.tk/man/tcl8.4/TclCmd/re_syntax.htm ).
Okay either way. Thanks,
Segher