This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix c++/78621 generic lambda mangling


On 12/08/2016 02:08 PM, Jason Merrill wrote:

Right.  Which is because they act as normal template parameters rather
than like the auto type-specifier does in, say, a variable declaration.
But indeed this produces bad mangling, and using Da in the mangling of a
generic lambda seems reasonable.  You've probably seen my mail to the
ABI list about it.  Are you still on that list?

Yes, thanks.

This use of tsubst can meet {TYPE,EXPR}_PARAMETER_PACKs, so I had to
extend tsubst to process those objects.

Hmm, we have deliberately avoided this in the past, since pack
expansions mean different things in different contexts.  Can you use
tsubst_arg_types instead?

... will investigate.

Also, the name "make_auto_for_mangle" doesn't really indicate that it's
doing a substitution of the function parameter types.

yeah, probably not the best name anymore. (it started out as just creating the single auto type, but then I moved all the other stuff into it.)

nathan
--
Nathan Sidwell


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]