This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] [AArch64] Fix PR71112
- From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
- To: "Hurugalawadi, Naveen" <Naveen dot Hurugalawadi at cavium dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Richard Earnshaw <Richard dot Earnshaw at arm dot com>, Marcus Shawcroft <marcus dot shawcroft at arm dot com>, "Pinski, Andrew" <Andrew dot Pinski at cavium dot com>, James Greenhalgh <james dot greenhalgh at arm dot com>
- Date: Mon, 05 Dec 2016 11:26:24 +0000
- Subject: Re: [PATCH] [AArch64] Fix PR71112
- Authentication-results: sourceware.org; auth=none
- References: <CO2PR07MB269488C6223A95A66CCCBC2B83B70@CO2PR07MB2694.namprd07.prod.outlook.com>
[CC'ing James]
On 23/11/16 05:25, Hurugalawadi, Naveen wrote:
Hi,
Please find attached the patch that fixes PR71112.
The current implementation that handles SYMBOL_SMALL_GOT_28K in
aarch64_load_symref_appropriately access the high part of RTX for Big-Endian
mode which results in ICE for ILP32.
The attached patch modifies it by accessing the lower part for both Endian
and fixes the issue.
Please review the patch and let me know if its okay?
This looks ok to me as I had independently come up with an identical patch for it.
But I can't approve.
Thanks,
Kyrill
2016-11-23 Andrew PInski <apinski@cavium.com>
gcc
* config/aarch64/aarch64.c (aarch64_load_symref_appropriately):
Access the lower part of RTX appropriately.
gcc/testsuite
* gcc.target/aarch64/pr71112.c : New Testcase.