Re: [PATCH] Added noexcept on constructors

[Ville Voutilainen <ville dot voutilainen at gmail dot com>]

On 3 December 2016 at 14:20, Ville Voutilainen
<ville.voutilainen@gmail.com> wrote:
> On 3 December 2016 at 13:31, Aditya K <hiraditya@msn.com> wrote:
>> ---
>>  libstdc++-v3/ChangeLog               | 3 +++
>>  libstdc++-v3/src/c++11/shared_ptr.cc | 4 ++--
>>  2 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog
>> index 08d9229..18924c4 100644
>> --- a/libstdc++-v3/ChangeLog
>> +++ b/libstdc++-v3/ChangeLog
>> @@ -1,3 +1,6 @@
>> +2016-12-03  Aditya Kumar  <hiraditya@msn.com>
>> +       * src/c++11/shared_ptr.cc: Added noexcept on constructors.
>> +
>>  2016-12-01  David Edelsohn  <dje.gcc@gmail.com>
>
>
> Please separate the ChangeLogs from patches - Changelog needs to be
> temporally linear, and doesn't merge well.
> For reference, see the ChangeLog part of https://gcc.gnu.org/contribute.html


I also failed to mention that a proper ChangeLog entry contains the
context of the change, for example

2016-12-01  Ville Voutilainen  <ville.voutilainen@gmail.com>

        Implement LWG 2766,
        Swapping non-swappable types and LWG 2749,
        swappable traits for variants.
        * include/bits/move.h (swap(_Tp&, _Tp&)): Constrain
        with __is_tuple_like.

Note the parenthesized mention of swap.