This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 5/9] Introduce selftest::locate_file (v4)

From: Bernd Schmidt <bschmidt at redhat dot com>
To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Thu, 1 Dec 2016 14:29:38 +0100
Subject: Re: [PATCH 5/9] Introduce selftest::locate_file (v4)
Authentication-results: sourceware.org; auth=none
References: <1478898935-46932-1-git-send-email-dmalcolm@redhat.com> <1478898935-46932-6-git-send-email-dmalcolm@redhat.com>

On 11/11/2016 10:15 PM, David Malcolm wrote:

+  /* Makefile.in has -fself-test=$(srcdir)/testsuite/selftests, so that
+     flag_self_test contains the path to the selftest subdirectory of the
+     source tree (without a trailing slash).  Copy it up to
+     path_to_selftest_files, to avoid selftest.c depending on
+     option-handling.  */
+  path_to_selftest_files = flag_self_test;
+

What kind of dependency are you avoiding? If it's just one include I'dprefer to get rid of the extraneous variable.


Otherwise ok.


Bernd

Follow-Ups:
- Re: [PATCH 5/9] Introduce selftest::locate_file (v4)
  - From: David Malcolm
- Re: [PATCH 5/9] Introduce selftest::locate_file (v4)
  - From: David Malcolm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]