This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -fsanitize=undefined with PCH (PR sanitizer/66343)
- From: Marek Polacek <polacek at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Richard Biener <rguenther at suse dot de>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 5 Oct 2016 17:28:39 +0200
- Subject: Re: [PATCH] Fix -fsanitize=undefined with PCH (PR sanitizer/66343)
- Authentication-results: sourceware.org; auth=none
- References: <20161005152523.GA16311@tucnak.redhat.com>
On Wed, Oct 05, 2016 at 05:25:23PM +0200, Jakub Jelinek wrote:
> Hi!
>
> As mentioned in the PR, ubsan.c uses ASM_GENERATE_INTERNAL_LABEL with
> static counters that aren't registered with GC, and those functions can be
> called already during parsing, so we can get clashes between labels
> created during PCH creation and labels created afterwards.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
Looks fine but I can't approve.
Marek