This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] selftest.h: mark failure functions with "noreturn"

From: Eric Gallager <egall at gwmail dot gwu dot edu>
To: Bernd Schmidt <bschmidt at redhat dot com>
Cc: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org
Date: Fri, 26 Aug 2016 13:58:51 -0400
Subject: Re: [PATCH] selftest.h: mark failure functions with "noreturn"
Authentication-results: sourceware.org; auth=none
References: <1472227524-9060-1-git-send-email-dmalcolm@redhat.com> <244b16a9-6227-fd91-03c2-a3d9751c14ce@redhat.com>

On 8/26/16, Bernd Schmidt <bschmidt@redhat.com> wrote:
> On 08/26/2016 06:05 PM, David Malcolm wrote:
>> selftest::fail and selftest::fail_formatted call abort.  Marking
>> them as "noreturn" can help eliminate false warnings about unreachable
>> code in selftests.
>>
>> Successfully bootstrapped&regrtested on x86_64-pc-linux-gnu.
>>
>> OK for trunk?
>
> Don't we want to wrap this in some ATTRIBUTE_NORETURN macro for
> portability?
>


One already exist in include/ansidecl.h; lots of files already use the macro:
$ git grep ATTRIBUTE_NORETURN | wc -l
      96
So yeah, I'd say it should be used here, too.

Eric

References:
- [PATCH] selftest.h: mark failure functions with "noreturn"
  - From: David Malcolm
- Re: [PATCH] selftest.h: mark failure functions with "noreturn"
  - From: Bernd Schmidt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]