This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fix fallout of pr22051-2.c on arm
- From: Richard Biener <rguenther at suse dot de>
- To: Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>
- Cc: matthew dot wahab at foss dot arm dot com, gcc Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 4 Aug 2016 09:09:18 +0200 (CEST)
- Subject: Re: fix fallout of pr22051-2.c on arm
- Authentication-results: sourceware.org; auth=none
- References: <CAAgBjMmzMaKxk-tbXuctc_swEcpani8sHjKkmTASksNF7a3cmA@mail.gmail.com>
On Thu, 4 Aug 2016, Prathamesh Kulkarni wrote:
> Hi,
> The attached patch fixes pr22051-2.c which regressed due to
> r238754. Matthew, could you please confirm if this patch fixes the
> test-case for you ?
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
> Cross tested on arm*-*-*.
> OK for trunk ?
Note that if function pointer types are really the issue then
you also need to handle METHOD_TYPE, thus sth like
&& ! FUNC_OR_METHOD_TYPE_P (TREE_TYPE (TREE_TYPE (@0))
please also add a comment for this non-obvious thing. I believe
we should simply apply function pointer canonicalization for
comparisons early during gimplification - exposing this target
detail only during RTL expansion makes generic optimization hard.
Ok with those changes.
Thanks,
Richard.