This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C/C++ PATCH to improve location for -Wparentheses (PR c/71926)

From: Jeff Law <law at redhat dot com>
To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Joseph Myers <joseph at codesourcery dot com>, Jason Merrill <jason at redhat dot com>
Date: Fri, 29 Jul 2016 09:31:40 -0600
Subject: Re: C/C++ PATCH to improve location for -Wparentheses (PR c/71926)
Authentication-results: sourceware.org; auth=none
References: <20160729143512.GR7007@redhat.com>

On 07/29/2016 08:35 AM, Marek Polacek wrote:

These two parentheses warnings were missing proper location arguments, so the
location info was less than satisfying.  Fixed thus.

Bootstrapped/regtested on x86_64-linux, ok for trunk?

2016-07-29  Marek Polacek  <polacek@redhat.com>

	PR c/71926
	* c-common.c (c_common_truthvalue_conversion): Use LOCATION for the
	parentheses warning.

	* semantics.c (maybe_convert_cond): Use the location of COND for the
	parentheses warning.

	* g++.dg/warn/Wparentheses-30.C: New test.
	* gcc.dg/Wparentheses-14.c: New test.

OK.
jeff

References:
- C/C++ PATCH to improve location for -Wparentheses (PR c/71926)
  - From: Marek Polacek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]