Re: [PATCH 2/17][Testsuite] Add a selector for ARM FP16 alternative format support.

[Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>]

On Tue, May 17, 2016 at 3:24 PM, Matthew Wahab
<matthew.wahab@foss.arm.com> wrote:
> The ARMv8.2-A FP16 extension only supports the IEEE format for FP16
> data. It is not compatible with the option -mfp16-format=none nor with
> the option -mfp16-format=alternative (selecting the ARM alternative FP16
> format). Using either with the FP16 extension will trigger a compiler
> error.
>
> This patch adds the selector arm_fp16_alternative_ok to the testsuite's
> target-support code to allow tests to require support for the
> alternative format. It also adds selector arm_fp16_none_ok to check
> whether -mfp16-format=none is a valid option for the target.  The patch
> also updates existing tests to make use of the new selectors.
>
> Tested the series for arm-none-linux-gnueabihf with native bootstrap and
> make check and for arm-none-eabi and armeb-none-eabi with make check on an
> ARMv8.2-A emulator.
>
> Ok for trunk?
> Matthew
>
> 2016-05-17  Matthew Wahab  <matthew.wahab@arm.com>
>
>         * doc/sourcebuild.texi (ARM-specific attributes): Add entries for
>         arm_fp16_alternative_ok and arm_fp16_none_ok.
>
> testsuite/
> 2016-05-17  Matthew Wahab  <matthew.wahab@arm.com>
>
>         * g++.dg/ext/arm-fp16/arm-fp16-ops-3.C: Use
>         arm_fp16_alternative_ok.
>         * g++.dg/ext/arm-fp16/arm-fp16-ops-4.C: Likewise.
>         * gcc.dg/torture/arm-fp16-int-convert-alt.c: Likewise.
>         * gcc/testsuite/gcc.dg/torture/arm-fp16-ops-3.c: Likewise.
>         * gcc/testsuite/gcc.dg/torture/arm-fp16-ops-4.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-1.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-10.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-11.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-12.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-2.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-3.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-4.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-5.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-6.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-7.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-8.c: Likewise.
>         * gcc.target/arm/fp16-compile-alt-9.c: Likewise.
>         * gcc.target/arm/fp16-compile-none-1.c: Use arm_fp16_none_ok.
>         * gcc.target/arm/fp16-compile-none-2.c: Likewise.
>         * gcc.target/arm/fp16-rounding-alt-1.c: Use
>         arm_fp16_alternative_ok.
>         * lib/target-supports.exp
>         (check_effective_target_arm_fp16_alternative_ok_nocache): New.
>         (check_effective_target_arm_fp16_alternative_ok): New.
>         (check_effective_target_arm_fp16_none_ok_nocache): New.
>         (check_effective_target_arm_fp16_none_ok): New.
>


OK.

Thanks,
ramana