This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Adapt the numbering scheme (PR gcov-profile/64874)
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Martin Liška <mliska at suse dot cz>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, nathan at codesourcery dot com, Jan Hubicka <hubicka at ucw dot cz>
- Date: Fri, 22 Jul 2016 15:20:44 +0200
- Subject: Re: [PATCH] Adapt the numbering scheme (PR gcov-profile/64874)
- Authentication-results: sourceware.org; auth=none
- References: <firstname.lastname@example.org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jul 22, 2016 at 01:46:44PM +0200, Martin Liška wrote:
> As described in the PR, current numbering scheme in gcov-io.h would overflow in couple of years.
> Thus, I'm suggesting to switch from:
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
Won't this clash with the already released versions?
Unless you start e.g. using different release_status letters from the past
(but that is complicated with vendor supplied DEV-PHASE), won't
say gcc 3.4.0 and gcc 30.4.1 have the same string?
Wouldn't it be better to just use letters for the major/10? As GCC major
didn't reach 10 yet, we only had [0-9][0-9][0-9]. in the past, so I think:
- v = (major < 10 ? '0' : 'A' - 10) + major;
- v = (minor / 10) + '0';
- v = (minor % 10) + '0';
+ v = (major / 10) + 'A';
+ v = (major % 10) + '0';
+ v = minor + '0';
would be better, then there will be no clash, and the versioning scheme will
allow until 259.9.