This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,rs6000] Consolidate Power9 Option Flags


Hello Kelvin,

On Thu, Jul 21, 2016 at 11:04:45AM -0600, Kelvin Nilsen wrote:
> This patch undocuments various compiler flags that are associated with
> different subsets of the full Power9 instruction set.  The benefits of
> hiding these option flags are to reduce testing complexity and to
> reduce the likelihood of user error (because certain combinations of
> flag values are not meaningful).  With this patch, users simply specify
> -mcpu=power9 and all of the relevant hidden (undocumented) flags are
> automatically enabled.
> 
> This patch has been bootstrapped and tested on powerpc64le-unkonwn-linux
> with no regressions.  Is this ok for the trunk?

Yes please.  One changelog nitpick...

> 	* config/rs6000/rs6000.h: Add macro definition of MASK_FLOAT128
> 	and change the macro definition of RS6000_BTM_FLOAT128 to correct
> 	an error that was discovered during the development of this patch.

	* config/rs6000/rs6000.h (MASK_FLOAT128): New macro.
	(RS6000_BTM_FLOAT128): Use it.

Thanks,


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]