This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4)
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>
- Cc: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, Thomas Schwinge <thomas at codesourcery dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Thu, 21 Jul 2016 12:54:20 +0200
- Subject: Re: [PATCH, Fortran, OpenACC] Fix PR70598, Fortran host_data ICE (ping x4)
- Authentication-results: sourceware.org; auth=none
- References: <2b4f59d5-be38-2814-27bb-73aa7ffb4b8f@codesourcery.com> <F1E73865-ED59-4FFB-8EEA-D3CB26281745@gmail.com> <e2ad8868-fdda-de14-6c59-ad43c25e4d46@codesourcery.com> <7db676cf-e30d-f37c-d173-169b2d9eebf4@codesourcery.com> <57862B95.7080002@codesourcery.com> <1ec267d3-4e9e-e56a-e7a4-3bbdca9412cd@codesourcery.com>
Hi Chung-Lin,
I was ignoring your patch on the grounds that one of the omp gurus
should deal with it. That says, it looks OK for trunk to me.
I presume that fortran/host_data-1.f90 should have the XFAIL removed?
Cheers
Paul
On 21 July 2016 at 11:28, Chung-Lin Tang <cltang@codesourcery.com> wrote:
> Ping x4
>
> On 2016/7/13 7:52 PM, Chung-Lin Tang wrote:
>> Ping x3
>>
>> On 06/21/2016 02:18 PM, Chung-Lin Tang wrote:
>>> Ping x2
>>>
>>> On 2016/6/7 08:03 PM, Chung-Lin Tang wrote:
>>>> Ping.
>>>>
>>>> On 2016/5/11 02:57 AM, Bernhard Reutner-Fischer wrote:
>>>>> On May 9, 2016 4:26:50 PM GMT+02:00, Chung-Lin Tang <cltang@codesourcery.com> wrote:
>>>>>> Hi, this patch resolves an ICE for Fortran when using the OpenACC
>>>>>> host_data directive. Actually, rather than say resolve, it's more like
>>>>>> adjusting the front-end to same middle-end restrictions as C/C++,
>>>>>> namely that we only support pointers or arrays for host_data right now.
>>>>>>
>>>>>> This patch contains a little bit of adjustments in
>>>>>> fortran/openmp.c:resolve_omp_clauses(),
>>>>>> and some testcase adjustments. This has been tested without regressions
>>>>>> for Fortran.
>>>>>>
>>>>>> Is this okay for trunk?
>>>>>>
>>>>>> Thanks,
>>>>>> Chung-Lin
>>>>>>
>>>>>> 2015-05-09 Chung-Lin Tang <cltang@codesourcery.com>
>>>>>>
>>>>>> gcc/
>>>>>> * fortran/openmp.c (resolve_omp_clauses): Adjust use_device clause
>>>>>> handling to only allow pointers and arrays.
>>>>>
>>>>> Fortran has it's own ChangeLog. The patch itself looks somewhat plausible to me, fwiw, but Jakub or a FE maintainer has the
>>>>> say.
>>>>>
>>>>
>>>
>
--
The difference between genius and stupidity is; genius has its limits.
Albert Einstein