This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Use HOST_WIDE_INT_{,M}1{,U} some more


On Jul 19, 2016, at 5:46 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> 
> The result of exercises with sed in gcc/ directory.
> 
> 2016-07-19  Uros Bizjak  <ubizjak@gmail.com>
> 
>    * builtins.c: Use HOST_WIDE_INT_1 instead of (HOST_WIDE_INT) 1,
>    HOST_WIDE_INT_1U instead of (unsigned HOST_WIDE_INT) 1,
>    HOST_WIDE_INT_M1 instead of (HOST_WIDE_INT) -1 and
>    HOST_WIDE_INT_M1U instead of (unsigned HOST_WIDE_INT) -1.

Maybe it's just me, but I actually find the new forms you put in to be more complex, not less complex.  The reason is that that the code that there are 4 words one has to learn what they mean instead of 1 word.  Learning 4 words is 4x more complex than learning 1 word.   The casting increases the complexity some, but not enough to overcome the loss of simplicity that all the new terms bring.  And that's _with_ my knowledge and experience of the new forms you use.  To a beginner, those forms are even more cryptic I think.  I don't feel too strongly about this.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]