This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v5] Allocate constant size dynamic stack space in the prologue
On Fri, Jul 15, 2016 at 01:51:51PM +0200, Bernd Schmidt wrote:
> On 07/14/2016 11:10 AM, Dominik Vogt wrote:
>
> >- if (flag_stack_usage_info)
> >- stack_usage_size += extra;
> >+ /*!!!*/
> >+ if (flag_stack_usage_info && pstack_usage_size)
> >+ *pstack_usage_size += extra;
>
> What does the comment mean?
It means that I wanted to look at that code location for some
reason and forgot to do so. Need to check why I've put it in
there in the first place.
> Other than that it looks ok, although I still feel uneasy about the
> unexplained movement of code since v1 - next time you fix a bug in a
> patch, please document what happened.
Yep.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany