This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5] Allocate constant size dynamic stack space in the prologue


On 07/14/2016 11:10 AM, Dominik Vogt wrote:

-  if (flag_stack_usage_info)
-    stack_usage_size += extra;
+  /*!!!*/
+  if (flag_stack_usage_info && pstack_usage_size)
+    *pstack_usage_size += extra;

What does the comment mean? Whatever it is needs to be addressed and the comment removed.

Other than that it looks ok, although I still feel uneasy about the unexplained movement of code since v1 - next time you fix a bug in a patch, please document what happened.


Bernd


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]