This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Fix FFI return type for proxy classes


Tom Tromey <tom@tromey.com> writes:
> >>>>> "Matthew" == Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
> 
> Matthew> Tested on: x86_64-pc-linux-gnu (default and -m32), mips-linux-gnu
> Matthew> mipsel-linux-gnuabi64 with no regressions. The new test only failed
> Matthew> on mips-linux-gnu prior to patching libjava.
> 
> Matthew> libjava/
> Matthew> 	* java/lang/reflect/natVMProxy.cc (unbox): Use ffi_arg for
> Matthew> 	integer return types smaller than a word.
> Matthew> 	* testsuite/libjava.jar/ReturnInvocationHandler.java: New file.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.jar: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.java: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.out: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnProxyTest.xfail: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnTypes.java: Likewise.
> Matthew> 	* testsuite/libjava.jar/ReturnTypesImpl.java: Likewise.
> 
> Thanks for writing this.
> This is ok.

Thanks for the review.

Committed as r238312. This also needs a backport to GCC 5 and 6 but I will
give it a week or so before proposing.

Thanks,
Matthew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]