This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/6] Don't run instrumented value profiler changes with afdo
- From: Jeff Law <law at redhat dot com>
- To: Andi Kleen <andi at firstfloor dot org>, gcc-patches at gcc dot gnu dot org
- Cc: hubicka at ucw dot cz, Andi Kleen <ak at linux dot intel dot com>
- Date: Wed, 13 Jul 2016 15:30:56 -0600
- Subject: Re: [PATCH 2/6] Don't run instrumented value profiler changes with afdo
- Authentication-results: sourceware.org; auth=none
- References: <20160627015024.23444-1-andi@firstfloor.org> <20160627015024.23444-2-andi@firstfloor.org> <20160627015024.23444-3-andi@firstfloor.org>
On 06/26/2016 07:50 PM, Andi Kleen wrote:
From: Andi Kleen <ak@linux.intel.com>
The pass to transform gimple based on value profiling runs with autofdo
on, but currently every transformation fails. For indirect calls autofdo
does it on its own, and it doesn't suppport other value profiling. So don't
run this pass when autofdo is active. This also avoids bogus
dump file entries.
gcc/:
* 2016-06-26 Andi Kleen <ak@linux.intel.com>
* value-prof.c (gimple_value_profile_transformations): Don't run
when auto_profile is on.
I don't think that comment is really correct. There's all kinds of
things going on with div/mod operations, turning string builtins into
straightline code, etc that I see in value-prof that aren't done by
autofdo AFAICT.
I can live with the change if the comment is corrected.
jeff