This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3 PATCH] Implement P0307R2, Making Optional Greater Equal Again.


On 11/07/16 23:41 +0300, Ville Voutilainen wrote:
@@ -785,41 +785,60 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
	}
    };

+  template<typename _Tp>
+    using __optional_relop_t =
+    enable_if_t<is_constructible<bool, _Tp>::value, bool>;

Should this be is_convertible<_Tp, bool> instead?

  template<typename _Tp>
-    constexpr bool
+    constexpr auto
    operator!=(const optional<_Tp>& __lhs, _Tp const& __rhs)

Dunno why this has _Tp const& rather than const _Tp&, could you fix it
while you're in the file anyway? It's a bit confusing to have one
place using a different style.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]