This is the mail archive of the
mailing list for the GCC project.
Re: Implement -Wswitch-fallthrough
- From: Jeff Law <law at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 12 Jul 2016 10:10:23 -0600
- Subject: Re: Implement -Wswitch-fallthrough
- Authentication-results: sourceware.org; auth=none
- References: <20160711194340.GI13963@redhat.com>
On 07/11/2016 01:43 PM, Marek Polacek wrote:
The switch fallthrough has been widely considered a design defect in C, a
misfeature or, to use Marshall Cline's definition, evil. The overwhelming
majority of the time you don't want to fall through to the next case, but it is
easy to forget to "break" at the end of the case, making this far too error
prone. Yet GCC (and probably other compilers, too) doesn't have the ability to
warn in this case. A feature request for such warning was opened back in 2002,
but it's mostly been untouched since. But then the [[fallthrough]] attribute was
approved for C++17 , and that's what has got me to do all this.
[ ... ]
This is going to be rather contentious. So as we're hashing through
that, can you split off the patches which fix bugs rather than those
which add fallthru annotations?