This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Convert TYPE_ALIGN_OK into an TYPE_LANG_FLAG


On 07/10/2016 09:32 AM, Bernd Edlinger wrote:
On 07/10/16 10:23, Eric Botcazou wrote:
I expect it still has an effect due to the same reason as the
DECL_OFFSET_ALIGN thing - memory reference expansion doesn't gather
information from the full reference but tries to re-cover it from
the pieces returned from get_inner_reference.  So I guess we need
to fix that first.

The situation is a bit different though, because the main (and single?) case
for which TYPE_ALIGN_OK had been necessary in the middle-end was made obsolete
by a gigi change at some point.  And indeed extensive testing of Bernd's patch
on a strict-alignment platform didn't reveal any issue.

So no objection to the patch on principle by me.


Thank you, Eric.

So following Jeff's suggestion, here is an updated patch that allocates
a new lang_flag_7 out of the spare bits in tree_type_common.

The only difference to the previous version is in tree-core.h where
tree_type_common is declared, and print-tree.c where the new flag
is printed.


Boot-strapped and reg-tested on armv7-linux-gneabihf.
OK for trunk?
OK.
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]