This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH PR c/71699] Handle pointer arithmetic in nonzero tree checks


Yep, there are some test issues -- I don't have time right now but
plan to investigate further later.
-Manish


On Sat, Jul 9, 2016 at 12:06 AM, Jeff Law <law@redhat.com> wrote:
> On 07/06/2016 11:22 AM, Bernd Schmidt wrote:
>>
>> On 07/05/2016 12:41 PM, Richard Biener wrote:
>>>
>>> On Fri, Jul 1, 2016 at 3:10 PM, Manish Goregaokar <manish@mozilla.com>
>>> wrote:
>>>>
>>>> Added a test:
>>>
>>>
>>> Ok if this passed bootstrap/regtest.
>>
>>
>>>> +      return flag_delete_null_pointer_checks
>>>> +            && (tree_expr_nonzero_warnv_p (op0, strict_overflow_p)
>>>> +                || tree_expr_nonzero_warnv_p (op1, strict_overflow_p));
>>>>      case PLUS_EXPR:
>>
>>
>> But please fix the wrapping - multi-line expressions like this should be
>> enclosed in parentheses to make the editor deal with them correctly.
>
> I believe this patch regresses several tests in constexpr-array-ptr10.C.
>
> jeff
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]