This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH], PR 71806, Fix -mfloat128/-mfloat128-hardware defaults on power9


On Fri, Jul 08, 2016 at 10:17:14AM -0400, Michael Meissner wrote:
> > >    /* IEEE 128-bit floating point hardware instructions imply enabling
> > >       __float128.  */
> > >    if (TARGET_FLOAT128_HW
> > > -      && (rs6000_isa_flags & (OPTION_MASK_P9_VECTOR
> > > -			      | OPTION_MASK_DIRECT_MOVE
> > > -			      | OPTION_MASK_UPPER_REGS_DI
> > > -			      | OPTION_MASK_UPPER_REGS_DF
> > > -			      | OPTION_MASK_UPPER_REGS_SF)) == 0)
> > > +      && (rs6000_isa_flags & ISA_3_0_MASKS_IEEE) != ISA_3_0_MASKS_IEEE)
> > >      {
> > >        if ((rs6000_isa_flags_explicit & OPTION_MASK_FLOAT128_HW) != 0)
> > >  	error ("-mfloat128-hardware requires full ISA 3.0 support");
> > 
> > That is not the same thing...  New one looks better, is this a bugfix?
> > The changelog doesn't say.
> 
> I just moved the OPTIONS_MASKS_* used here to a common macro that is checked
> earlier to enable hardware support if -mfloat128.

The old code tests if all options are off; the new if any are off.


Segher


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]