This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH trivial] Fix PR71214 (__cpp_rvalue_references vs. __cpp_rvalue_reference)


On 2016.07.05 at 12:21 -0400, Jason Merrill wrote:
> On Tue, Jul 5, 2016 at 6:44 AM, Richard Biener
> <richard.guenther@gmail.com> wrote:
> > On Tue, Jul 5, 2016 at 12:07 PM, Markus Trippelsdorf
> > <markus@trippelsdorf.de> wrote:
> >> Hi,
> >>
> >> as PR71214 points out gcc uses a wrong feature test macro for C++11
> >> rvalue references: __cpp_rvalue_reference instead of the correct
> >> __cpp_rvalue_references.
> >>
> >> The fix is trivial. Ok for trunk and active branches?
> >
> > I wonder if we should to retain the (bogus) old defines for backward
> > compatibility.
> 
> Hmm.  The original SD-6 proposal
> (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3694.htm)
> used the singular, but it soon changed to plural; I haven't been able
> to find any email discussion of the change.  I think let's keep both
> defines.

Ok, no problem. But what about the testsuite fallout?

1) Change to plural as in my patch.
2) Add additional tests for plural.
3) Don't change anything at all.

-- 
Markus


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]