This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH PR70729] The second part of patch.


On Sun, Jul 3, 2016 at 9:16 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Sun, Jul 03, 2016 at 08:56:44AM -0700, H.J. Lu wrote:
>> --- /dev/null
>> +++ b/libgomp/testsuite/libgomp.fortran/pr71734-1.f90
>> @@ -0,0 +1,110 @@
>> +! { dg-do run { target avx_runtime } }
>> +! { dg-additional-options "-msse2" }
>> +! The same as simd3.f90, but compiled with -msse2.  we run it only on
>> +! AVX machine where simd4.f90 is compiled with -mavx.
>
> Please just
> include 'simd3.f90'
> here instead.  Also, s/simd4.f90/simd3.f90/ above.
>
>> diff --git a/libgomp/testsuite/libgomp.fortran/pr71734-2.f90 b/libgomp/testsuite/libgomp.fortran/pr71734-2.f90
>> new file mode 100644
>> index 0000000..1cad4c1
>> --- /dev/null
>> +++ b/libgomp/testsuite/libgomp.fortran/pr71734-2.f90
>> @@ -0,0 +1,104 @@
>> +! { dg-do run { target avx_runtime } }
>> +! { dg-additional-options "-msse2" }
>> +! The same as simd4.f90, but compiled with -msse2.  we run it only on
>> +! AVX machine where simd4.f90 is compiled with -mavx.
>> +
>
> Similarly.
> Ok with those changes.
>

This is what I checked in.


-- 
H.J.
From 26e0da253574be0e6e8e4dd71b894dded0c92cba Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Sun, 3 Jul 2016 08:54:24 -0700
Subject: [PATCH] Add 2 tests for PR middle-end/71734

simd3.f90 and simd4.f90 fail only with -msse2.  But they are compiled
with -mavx on AVX machines.  Add 2 tests to compile simd3.f90 and
simd4.f90 with -msse2 on AVX machines.

	PR middle-end/71734
	* testsuite/libgomp.fortran/pr71734-1.f90: New test.
	* testsuite/libgomp.fortran/pr71734-2.f90: Likewise.
---
 libgomp/testsuite/libgomp.fortran/pr71734-1.f90 | 6 ++++++
 libgomp/testsuite/libgomp.fortran/pr71734-2.f90 | 6 ++++++
 2 files changed, 12 insertions(+)
 create mode 100644 libgomp/testsuite/libgomp.fortran/pr71734-1.f90
 create mode 100644 libgomp/testsuite/libgomp.fortran/pr71734-2.f90

diff --git a/libgomp/testsuite/libgomp.fortran/pr71734-1.f90 b/libgomp/testsuite/libgomp.fortran/pr71734-1.f90
new file mode 100644
index 0000000..9b36a33
--- /dev/null
+++ b/libgomp/testsuite/libgomp.fortran/pr71734-1.f90
@@ -0,0 +1,6 @@
+! { dg-do run { target avx_runtime } }
+! { dg-additional-options "-msse2" }
+! The same as simd3.f90, but compiled with -msse2.  we run it only on
+! AVX machine where simd3.f90 is compiled with -mavx.
+
+include 'simd3.f90'
diff --git a/libgomp/testsuite/libgomp.fortran/pr71734-2.f90 b/libgomp/testsuite/libgomp.fortran/pr71734-2.f90
new file mode 100644
index 0000000..2a84f26
--- /dev/null
+++ b/libgomp/testsuite/libgomp.fortran/pr71734-2.f90
@@ -0,0 +1,6 @@
+! { dg-do run { target avx_runtime } }
+! { dg-additional-options "-msse2" }
+! The same as simd4.f90, but compiled with -msse2.  we run it only on
+! AVX machine where simd4.f90 is compiled with -mavx.
+
+include 'simd4.f90'
-- 
2.7.4


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]