This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: C, C++: Fix PR 69733 (bad location for ignored qualifiers warning)

From: Jeff Law <law at redhat dot com>
To: Bernd Schmidt <bschmidt at redhat dot com>, Joseph Myers <joseph at codesourcery dot com>, Bernd Schmidt <bernds_cb1 at t-online dot de>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jason Merrill <jason at redhat dot com>
Date: Tue, 21 Jun 2016 21:37:26 -0600
Subject: Re: C, C++: Fix PR 69733 (bad location for ignored qualifiers warning)
Authentication-results: sourceware.org; auth=none
References: <571A2697 dot 4050208 at t-online dot de> <alpine dot DEB dot 2 dot 20 dot 1604252015500 dot 26323 at digraph dot polyomino dot org dot uk> <572A128B dot 4060800 at redhat dot com>

On 05/04/2016 09:17 AM, Bernd Schmidt wrote:

On 04/25/2016 10:18 PM, Joseph Myers wrote:

On Fri, 22 Apr 2016, Bernd Schmidt wrote:

+/* Returns the smallest location != UNKNOWN_LOCATION in LOCATIONS,
+   considering only those c_declspec_words found in LIST, which
+   must be terminated by cdw_number_of_elements.  */
+
+static location_t
+smallest_type_quals_location (const location_t* locations,
+                  c_declspec_word *list)


I'd expect list to be a pointer to const...

@@ -6101,6 +6122,18 @@ grokdeclarator (const struct c_declarato
             qualify the return type, not the function type.  */
          if (type_quals)
            {
+        enum c_declspec_word ignored_quals_list[] =
+          {
+            cdw_const, cdw_volatile, cdw_restrict, cdw_address_space,
+            cdw_number_of_elements
+          };


  ... and ignored_quals_list to be static const here.

How's this? Fully retested on x86_64-linux.


Bernd

declspecs-v2.diff


c/
	PR c++/69733
	* c-decl.c (smallest_type_quals_location): New static function.
	(grokdeclarator): Try to find the correct location for an ignored
	qualifier.
cp/
	PR c++/69733
	* decl.c (grokdeclarator): Try to find the correct location for an
	ignored qualifier.
testsuite/
	PR c++/69733
	* c-c++-common/pr69733.c: New test.
	* gcc.target/i386/pr69733.c: New test.

It looks like this stalled...

Anyway, it's fine for the trunk.

Thanks,
Jeff

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]