This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] nvptx per-warp compiler-defined stacks (-msoft-stack)
- From: Alexander Monakov <amonakov at ispras dot ru>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 9 Jun 2016 23:11:35 +0300 (MSK)
- Subject: Re: [PATCH] nvptx per-warp compiler-defined stacks (-msoft-stack)
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LNX dot 2 dot 20 dot 1604201958390 dot 14803 at monopod dot intra dot ispras dot ru> <5718DED6 dot 60308 at acm dot org> <alpine dot LNX dot 2 dot 20 dot 1605201747400 dot 7578 at monopod dot intra dot ispras dot ru> <e83ec5f1-c8bd-9daa-584c-512cc20c36e3 at acm dot org> <alpine dot LNX dot 2 dot 20 dot 1605242133010 dot 22494 at monopod dot intra dot ispras dot ru> <ee9f48d3-0ea6-eb6a-858d-d0cb392073f9 at acm dot org> <alpine dot LNX dot 2 dot 20 dot 1606030012530 dot 26281 at monopod dot intra dot ispras dot ru> <2d5645d0-d81d-bc0f-38a4-407b2d1bce86 at acm dot org>
On Thu, 9 Jun 2016, Nathan Sidwell wrote:
> > (define_expand "restore_stack_block"
> > [(match_operand 0 "register_operand" "")
> > (match_operand 1 "register_operand" "")]
>
> you've not addressed my previous comments about this.
To be clear -- do you mean that "restore_stack_block" should have a comment
mentioning why "save_stack_block" is not overridden?
> > @@ -0,0 +1,25 @@
>
> > +char *__nvptx_stacks[32] __attribute__((shared,nocommon));
>
> Is there a reason this can't be in crt0?
It's also needed for offloading compilation, which doesn't link crt0.
> It should be 'void *' Also, why '32' when only slot zero is initialized?
> ISTM that this should be size 1.
Offloading will need the full width.
Thanks.
Alexander