This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: move increase_alignment from simple to regular ipa pass
- From: Richard Biener <rguenther at suse dot de>
- To: Prathamesh Kulkarni <prathamesh dot kulkarni at linaro dot org>
- Cc: gcc Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <jh at suse dot de>
- Date: Wed, 1 Jun 2016 15:07:08 +0200 (CEST)
- Subject: Re: move increase_alignment from simple to regular ipa pass
- Authentication-results: sourceware.org; auth=none
- References: <CAAgBjMnPdYP_t74nP2a+QCBfMRJCQw+H+kjwnVTFRnVrfnkaEA at mail dot gmail dot com>
On Wed, 1 Jun 2016, Prathamesh Kulkarni wrote:
> Hi Richard,
> This patch tries to move increase_alignment pass from small to regular ipa pass.
> Does the patch look correct ?
> Since we are only increasing alignment of varpool nodes, I am not sure
> if any ipa
> read/write hooks were necessary and passed NULL for them.
> Cross-tested on arm*-*-*, aarch64*-*-*,
> Bootstrap+test on aarch64-linux-gnu in progress.
I think the patch looks sensible apart from the fact that both
flag_section_anchors and flag_tree_vectorize can have different
states for each function. This would mean the pass should get
its own non-Optimization flag initialized by targets where
section anchors are usually used and it means you'd want to
walk IPA refs to see whether variables are used in a function
with both section anchors and vectorization enabled.
Honza may have further comments.
Thanks,
Richard.
> Thanks,
> Prathamesh
>
--
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nuernberg)