This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Remove the unused OMP_CLAUSE_DEVICE_RESIDENT
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, Cesar Philippidis <cesar at codesourcery dot com>
- Date: Tue, 31 May 2016 17:48:30 +0200
- Subject: Re: Remove the unused OMP_CLAUSE_DEVICE_RESIDENT
- Authentication-results: sourceware.org; auth=none
- References: <87wpmaqlii dot fsf at kepler dot schwinge dot homeip dot net>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, May 31, 2016 at 05:45:25PM +0200, Thomas Schwinge wrote:
> While working on something else, I came across the following. Cesar, can
> you please verify that this is really dead code in the Fortran front end,
> which currently is the only producer of OMP_CLAUSE_DEVICE_RESIDENT?
>
> Also, I noticed that the Fortran front end never creates OMP_CLAUSE_MAP
> with GOMP_MAP_LINK or GOMP_MAP_DEVICE_RESIDENT -- how is OpenACC declare
> working at all? Cesar, if this is not a simple question to answer,
> please file a GCC PR, for somebody to have a look later.
>
> Jakub, if the following patch is OK, should I also clean it up on release
> branches as applicable, or just on trunk?
It is ok for trunk, not worth backporting to any branches.
But your ChangeLog doesn't cover the changes you've actually done.
> Remove the unused OMP_CLAUSE_DEVICE_RESIDENT
>
> gcc/
> * tree-core.h (enum omp_clause_code): Remove
> OMP_CLAUSE_DEVICE_RESIDENT. Adjust all users.
Jakub