This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, OpenACC] Make reduction arguments addressable
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Chung-Lin Tang <cltang at codesourcery dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Cesar Philippidis <cesar_philippidis at mentor dot com>
- Date: Mon, 30 May 2016 18:53:41 +0200
- Subject: Re: [PATCH, OpenACC] Make reduction arguments addressable
- Authentication-results: sourceware.org; auth=none
- References: <fac841d6-320a-6de8-2bcd-07145151d0f3 at codesourcery dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, May 30, 2016 at 10:38:59PM +0800, Chung-Lin Tang wrote:
> Hi, a previous patch of Cesar's has made the middle-end omp-lowering
> automatically create and insert a tofrom (i.e. present_or_copy) map for
> parallel reductions. This allowed the user to not need explicit
> clauses to copy out the reduction result, but because reduction arguments
> are not marked addressable, async does not work as expected,
> i.e. the asynchronous copy-out results are not used in the compiler generated code.
If you need it only for async parallel/kernels? regions, can't you do that
only for those and not for others?
> This patch fixes this in the front-ends, I've tested this patch without
> new regressions, and fixes some C++ OpenACC tests that regressed after
> my last OpenACC async patch. Is this okay for trunk?
Testcases in the testsuite or others? If the latter, we should add them.
Jakub