This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [AArch64, 3/6] Reimplement frsqrte intrinsics

From: Jiong Wang <jiong dot wang at foss dot arm dot com>
To: James Greenhalgh <james dot greenhalgh at arm dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 27 May 2016 17:33:31 +0100
Subject: Re: [AArch64, 3/6] Reimplement frsqrte intrinsics
Authentication-results: sourceware.org; auth=none
References: <57430251 dot 6060902 at foss dot arm dot com> <57430271 dot 3070504 at foss dot arm dot com> <5743029C dot 60208 at foss dot arm dot com> <57440F94 dot 5010308 at foss dot arm dot com> <20160527132400 dot GG26495 at arm dot com>



On 27/05/16 14:24, James Greenhalgh wrote:

On Tue, May 24, 2016 at 09:23:48AM +0100, Jiong Wang wrote:

These intrinsics were implemented before the instruction pattern
"aarch64_rsqrte<mode>" added, that these intrinsics were implemented through
inline assembly.

This mirgrate the implementation to builtin.

gcc/
2016-05-23  Jiong Wang <jiong.wang@arm.com>

         * config/aarch64/aarch64-builtins.def (rsqrte): New builtins
for modes
         VALLF.
         * config/aarch64/aarch64-simd.md (aarch64_rsqrte_<mode>2):
Rename to
"aarch64_rsqrte<mode>".
         * config/aarch64/aarch64.c (get_rsqrte_type): Update gen* name.
         * config/aarch64/arm_neon.h (vrsqrts_f32): Remove inline
assembly.  Use
builtin.
         (vrsqrted_f64): Likewise.
         (vrsqrte_f32): Likewise.
         (vrsqrteq_f32): Likewise.
         (vrsqrteq_f64): Likewise.

This ChangeLog is not in the correct form.

It looks like you are missing vrsqrte_f64, could you please add that?

vrsqrte_f64 wasn't cleaned up in this patch because it's input type isfloat64x1 whichcaused trouble during fitting it into aarch64 builtin infrastructurecleanly.


I might missed some thing, will double check this.

References:
- [AArch64, 3/6] Reimplement frsqrte intrinsics
  - From: Jiong Wang
- Re: [AArch64, 3/6] Reimplement frsqrte intrinsics
  - From: James Greenhalgh

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]