This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AArch64, 5/6] Reimplement fabd intrinsics & merge rtl patterns
- From: James Greenhalgh <james dot greenhalgh at arm dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, <nd at arm dot com>
- Date: Fri, 27 May 2016 14:31:29 +0100
- Subject: Re: [AArch64, 5/6] Reimplement fabd intrinsics & merge rtl patterns
- Authentication-results: sourceware.org; auth=none
- Nodisclaimer: True
- References: <57430251 dot 6060902 at foss dot arm dot com> <57430271 dot 3070504 at foss dot arm dot com> <5743029C dot 60208 at foss dot arm dot com> <574302DA dot 6090803 at foss dot arm dot com> <574302FC dot 5050701 at foss dot arm dot com> <57440F9E dot 6040807 at foss dot arm dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
On Tue, May 24, 2016 at 09:23:58AM +0100, Jiong Wang wrote:
> These intrinsics were implemented before "fabd<mode>_3" introduces.
> Meanwhile
> the patterns "fabd<mode>_3" and "*fabd_scalar<mode>3" can be merged into a
> single "fabd<mode>3" using VALLF.
>
> This patch migrate the implementation to builtins backed by this pattern.
>
> gcc/
> 2016-05-23 Jiong Wang <jiong.wang@arm.com>
>
> * config/aarch64/aarch64-builtins.def (fabd): New builtins
> for modes
> VALLF.
> * config/aarch64/aarch64-simd.md (fabd<mode>_3): Extend
> modes from VDQF
> to VALLF.
> "*fabd_scalar<mode>3): Delete.
> * config/aarch64/arm_neon.h (vabds_f32): Remove inline assembly.
> Use builtin.
> (vabdd_f64): Likewise.
> (vabd_f32): Likewise.
> (vabdq_f32): Likewise.
> (vabdq_f64): Likewise.
>
This ChangeLog format is wrong.
It looks like you've missed vabd_f64, could you please add that?
> From 9bafb58055d4e379df7b626acd6aa80bdb0d4b22 Mon Sep 17 00:00:00 2001
> From: "Jiong.Wang" <jiong.wang@arm.com>
> Date: Mon, 23 May 2016 12:12:53 +0100
> Subject: [PATCH 5/6] 5
>
> ---
> gcc/config/aarch64/aarch64-builtins.def | 3 ++
> gcc/config/aarch64/aarch64-simd.md | 23 +++------
> gcc/config/aarch64/arm_neon.h | 87 ++++++++++++---------------------
> 3 files changed, 42 insertions(+), 71 deletions(-)
>
> diff --git a/gcc/config/aarch64/aarch64-builtins.def b/gcc/config/aarch64/aarch64-builtins.def
> index 1955d17..40baebe 100644
> --- a/gcc/config/aarch64/aarch64-builtins.def
> +++ b/gcc/config/aarch64/aarch64-builtins.def
> @@ -465,3 +465,6 @@
>
> /* Implemented by aarch64_rsqrts<mode>. */
> BUILTIN_VALLF (BINOP, rsqrts, 0)
> +
> + /* Implemented by fabd<mode>_3. */
This comment is incorrect, it should say "Implemented by fabd<mode>3.",
without the underscore.
> + BUILTIN_VALLF (BINOP, fabd, 3)
Thanks,
James