This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fixes to must-tail-call tests
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, David Malcolm <dmalcolm at redhat dot com>, jit at gcc dot gnu dot org, Andreas Schwab <schwab at linux-m68k dot org>
- Date: Fri, 27 May 2016 13:29:04 +0100
- Subject: Re: [PATCH] Fixes to must-tail-call tests
- Authentication-results: sourceware.org; auth=none
- References: <m21t4vpxbv dot fsf at linux-m68k dot org> <1464106264-58571-1-git-send-email-dmalcolm at redhat dot com> <ydd4m9mzdpb dot fsf at CeBiTec dot Uni-Bielefeld dot DE>
Hi Rainer,
On Wednesday 25 May 2016 11:31:12 Rainer Orth wrote:
> David Malcolm <dmalcolm@redhat.com> writes:
> > The following fixes the known failures of the must-tail-call tests.
> >
> > Tested with --target=
> > * aarch64-unknown-linux-gnu
> > * ia64-unknown-linux-gnu
> > * m68k-unknown-linux-gnu
> > * x86_64-pc-linux-gnu
>
> Even with this patch, there are still failures on sparc-sun-solaris2.12:
>
> FAIL: gcc.dg/plugin/must-tail-call-1.c -fplugin=./must_tail_call_plugin.so
> (test for excess errors)
>
> Excess errors:
> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/plugin/must-tail-call-1.c:1
> 2:10: error: cannot tail-call: target is not able to optimize the call into
> a sibling call
>
> FAIL: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so
> (test for excess errors)
>
> Excess errors:
> /vol/gcc/src/hg/trunk/local/gcc/testsuite/gcc.dg/plugin/must-tail-call-2.c:3
> 2:10: error: cannot tail-call: target is not able to optimize the call into
> a sibling call
Now that the logic is in place, you probably want to add sparc-sun-solaris in
plugin.exp to the the list of architecture where tail call plugin tests should
be skipped, alongside Thumb-1 ARM targets.
Best regards,
Thomas