This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, testsuite] Skip tail call tests on Thumb-1 targets

From: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>
To: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>, Mike Stump <mikestump at comcast dot net>, ramana dot radhakrishnan at arm dot com, richard dot earnshaw at arm dot com
Cc: gcc-patches at gcc dot gnu dot org, ro at cebitec dot uni-bielefeld dot de
Date: Thu, 26 May 2016 09:31:47 +0100
Subject: Re: [PATCH, testsuite] Skip tail call tests on Thumb-1 targets
Authentication-results: sourceware.org; auth=none
References: <2601986 dot QZc99cPl7b at e108577-lin> <43745E30-0D5D-4AF8-A399-4D0A84DE0181 at comcast dot net> <2031136 dot eCvnWLDzEh at e108577-lin>


On 26/05/16 09:24, Thomas Preudhomme wrote:

On Wednesday 25 May 2016 11:38:44 Mike Stump wrote:

On May 25, 2016, at 10:20 AM, Thomas Preudhomme

<thomas.preudhomme@foss.arm.com> wrote:

2016-05-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>

        * gcc.dg/plugin/plugin.exp: skip tail call tests for Thumb-1.

Is this ok for trunk?

Ok.  Normally I'd just punt to the arm folks. Better to Cc them on the
patch.  I watch all the changes to the .exp files, and will scream if
something seems to be going wrong.

Fair enough. I was not sure because it was touching to .exp files. What do ARM
maintainers think?

Is this ok for trunk?


From my perspective the check for tailcall availability on arm is
correct. I don't know whether the place you add it in is correct
as I'm not familiar with that .exp file, so if Mike has no objections
to it's placement I'd say it's ok.

Thanks,
Kyrill

Best regards,

Thomas

References:
- [PATCH, testsuite] Skip tail call tests on Thumb-1 targets
  - From: Thomas Preudhomme
- Re: [PATCH, testsuite] Skip tail call tests on Thumb-1 targets
  - From: Mike Stump
- Re: [PATCH, testsuite] Skip tail call tests on Thumb-1 targets
  - From: Thomas Preudhomme

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]