This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, testsuite] Skip tail call tests on Thumb-1 targets
- From: Thomas Preudhomme <thomas dot preudhomme at foss dot arm dot com>
- To: Mike Stump <mikestump at comcast dot net>, kyrylo dot tkachov at arm dot com, ramana dot radhakrishnan at arm dot com, richard dot earnshaw at arm dot com
- Cc: gcc-patches at gcc dot gnu dot org, ro at cebitec dot uni-bielefeld dot de
- Date: Thu, 26 May 2016 09:24:57 +0100
- Subject: Re: [PATCH, testsuite] Skip tail call tests on Thumb-1 targets
- Authentication-results: sourceware.org; auth=none
- References: <2601986 dot QZc99cPl7b at e108577-lin> <43745E30-0D5D-4AF8-A399-4D0A84DE0181 at comcast dot net>
On Wednesday 25 May 2016 11:38:44 Mike Stump wrote:
> On May 25, 2016, at 10:20 AM, Thomas Preudhomme
<thomas.preudhomme@foss.arm.com> wrote:
> > 2016-05-24 Thomas Preud'homme <thomas.preudhomme@arm.com>
> >
> > * gcc.dg/plugin/plugin.exp: skip tail call tests for Thumb-1.
> >
> > Is this ok for trunk?
>
> Ok. Normally I'd just punt to the arm folks. Better to Cc them on the
> patch. I watch all the changes to the .exp files, and will scream if
> something seems to be going wrong.
Fair enough. I was not sure because it was touching to .exp files. What do ARM
maintainers think?
Is this ok for trunk?
Best regards,
Thomas
diff --git a/gcc/testsuite/gcc.dg/plugin/plugin.exp b/gcc/testsuite/gcc.dg/plugin/plugin.exp
index 62f6797..321b4ba 100644
--- a/gcc/testsuite/gcc.dg/plugin/plugin.exp
+++ b/gcc/testsuite/gcc.dg/plugin/plugin.exp
@@ -90,6 +90,12 @@ foreach plugin_test $plugin_test_list {
if ![runtest_file_p $runtests $plugin_src] then {
continue
}
+ # Skip tail call tests on targets that do not have sibcall_epilogue.
+ if {[regexp ".*must_tail_call_plugin.c" $plugin_src]
+ && [istarget arm*-*-*]
+ && [check_effective_target_arm_thumb1]} then {
+ continue
+ }
set plugin_input_tests [lreplace $plugin_test 0 0]
plugin-test-execute $plugin_src $plugin_input_tests
}