This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only

From: Uros Bizjak <ubizjak at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, Rainer Orth <ro at cebitec dot uni-bielefeld dot de>, "Koval, Julia" <julia dot koval at intel dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "vaalfreja at gmail dot com" <vaalfreja at gmail dot com>, "law at redhat dot com" <law at redhat dot com>, "Zamyatin, Igor" <igor dot zamyatin at intel dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
Date: Wed, 25 May 2016 21:02:58 +0200
Subject: Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
Authentication-results: sourceware.org; auth=none
References: <CAMe9rOpjomeEMO+=8=XDyW+Q4SRVE1jPHL7xsvm5Ckqk3ySQcg at mail dot gmail dot com> <CAFULd4aksAjy1ejRu37U2abC5wxWSVUy4VsqzhNrtu7+gJ=VMw at mail dot gmail dot com> <CAMe9rOri+hx1E5RrPh30LNppNF77Y2r-C++cpGyKp7gk5ydTAQ at mail dot gmail dot com> <CAFULd4bnoiog=dUCcWG5M2h-rCfsYqdF55+0KSnPa-5X2c16rQ at mail dot gmail dot com> <CAMe9rOp5mWKj0J4gR=qczwXV0Z-6VSj6k7qBHGN9hnKn2w2yzA at mail dot gmail dot com> <CAFULd4aO1ugkKeX9NsadwW=6i6fUDB8G5=VfGK99+S7GyXxPzw at mail dot gmail dot com> <CAMe9rOrTqEKNZ23y13VHRk1GFMcLrZA+nEUOXpdLEwnUGP7Z8Q at mail dot gmail dot com> <CAFULd4brk56_if-tQsoJhkhgQv97Lw0ug22A46kakRW+nFWmPA at mail dot gmail dot com> <CAFULd4Z+-9Tx2nuY25EGByNQtQ8fy7047-Ub3S=-pydsUW=TKw at mail dot gmail dot com> <alpine dot DEB dot 2 dot 20 dot 1605242145310 dot 22670 at digraph dot polyomino dot org dot uk> <CAFULd4brcScr9iaJu-MRMqUc_NXX3-Xe9x8B-NfG8ZAWhOChdA at mail dot gmail dot com> <CAMe9rOqy+n9O=QG27SkzJNLx5dUjZh+=yjHSCifcmfVkdBZskA at mail dot gmail dot com>

Hello!

I have committed following patch that also implements
ix86_target_string handling of the new option.

2016-05-25  Uros Bizjak  <ubizjak@gmail.com>
        H.J. Lu  <hongjiu.lu@intel.com>

    PR target/70738
    * common/config/i386/i386-common.c
    (OPTION_MASK_ISA_GENERAL_REGS_ONLY_UNSET): New.
    (ix86_handle_option) <case OPT_mgeneral_regs_only>: Disable
    MPX, MMX, SSE and x87 instructions for -mgeneral-regs-only.
    * config/i386/i386.opt (ix86_target_flags): Add new Variable.
    (-mgeneral-regs-only): Add new option.
    * config/i386/i386.c (ix86_option_override_internal): Don't enable
    x87 instructions if only general registers are allowed.
    (ix86_target_string): Add ix86_flags argument. Handle additional
    flags options through ix86_flags argument.  Update all callers.
    * doc/invoke.texi: Document -mgeneral-regs-only.

testsuite/ChangeLog:

2016-05-25  H.J. Lu  <hongjiu.lu@intel.com>

    PR target/70738
    * gcc.target/i386/pr70738-1.c: New test.
    * gcc.target/i386/pr70738-2.c: Likewise.
    * gcc.target/i386/pr70738-3.c: Likewise.
    * gcc.target/i386/pr70738-4.c: Likewise.
    * gcc.target/i386/pr70738-5.c: Likewise.
    * gcc.target/i386/pr70738-6.c: Likewise.
    * gcc.target/i386/pr70738-7.c: Likewise.
    * gcc.target/i386/pr70738-8.c: Likewise.
    * gcc.target/i386/pr70738-9.c: Likewise.


Added is also a removal of a couple of unneeded variables:

2016-05-25  Uros Bizjak  <ubizjak@gmail.com>

    * config/i386/i386.opt (ix86_target_flags_explicit): Remove.
    (x_ix86_target_flags_explicit): Remove.
    * config/i386/i386.c (ix86_function_specific_save): Do not copy
    x_ix86_target_flags_explicit.
    (ix86_function_specific_restore): Ditto.

Patch was bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.

Committed to mainline SVN.

Uros.

Attachment: p.diff.txt
Description: Text document

References:
- [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: H.J. Lu
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Uros Bizjak
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: H.J. Lu
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Uros Bizjak
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: H.J. Lu
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Uros Bizjak
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: H.J. Lu
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Uros Bizjak
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Uros Bizjak
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Joseph Myers
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: Uros Bizjak
- Re: [PATCH] Use flag_general_regs_only with -mgeneral-regs-only
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]