This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR71230
- From: Richard Biener <rguenther at suse dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 24 May 2016 16:16:47 +0200 (CEST)
- Subject: Re: [PATCH] Fix PR71230
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 11 dot 1605241527410 dot 18037 at t29 dot fhfr dot qr> <20160524141325 dot GG28550 at tucnak dot redhat dot com>
On Tue, 24 May 2016, Jakub Jelinek wrote:
> On Tue, May 24, 2016 at 03:28:42PM +0200, Richard Biener wrote:
> > The following fixes the ICEs in PR71230.
> >
> > Bootstrap and regtest running on x86_64-unknown-linux-gnu.
>
> Wouldn't it be enough to use TYPE_SIZE_UNIT instead of TYPE_PRECISION
> for the non-INTEGRAL_TYPE_Ps and just deal with it at the bswap_replace
> point? I mean, if we don't want to optimize those further (the tests I've
> posted in the PR), then it is just a matter of creating low part
> BIT_FIELD_REF instead of the one we have and use that. This patch as is
> will I think not attempt to optimize the testcase with unsigned char l[8];
> array instead of two ints.
Yes, but TYPE_PRECISION is used in multiple places and I'd prefer to
fix the ICE quickly. For vector types I think we want to try
replacement with a VEC_PERM_EXPR even.
Richard.