This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] Minor cleanup to allocate_dynamic_stack_space
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, vogt at linux dot vnet dot ibm dot com, Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Date: Fri, 20 May 2016 23:44:28 +0200
- Subject: Re: [RFA] Minor cleanup to allocate_dynamic_stack_space
- Authentication-results: sourceware.org; auth=none
- References: <20160429221242 dot GA2205 at linux dot vnet dot ibm dot com> <34a785ea-bdd2-023c-4c02-a31dbadf0142 at redhat dot com> <5a4bf204-9919-7930-affe-f854f6ad9171 at redhat dot com>
> So here's that cleanup. The diffs are larger than one might expect
> because of the reindentation that needs to happen. So I've included a
> -b diff variant which shows how little actually changed here.
I'm wondering if it isn't counter-productive. The ??? comment is explicit
about where the problem comes from: STACK_POINTER_OFFSET used to be defined
only when needed, now it's always defined.
So I think that we should try to restore the initial state, this will very
likely generate fewer alignment operations, for example:
#if defined (STACK_DYNAMIC_OFFSET)
if (1)
#else
if (STACK_POINTER_OFFSET)
#endif
{
must_align = true;
extra_align = BITS_PER_UNIT;
}
--
Eric Botcazou