This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH to improve dump_decl (PR c++/71075)
- From: Jason Merrill <jason at redhat dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 19 May 2016 16:53:26 -0400
- Subject: Re: C++ PATCH to improve dump_decl (PR c++/71075)
- Authentication-results: sourceware.org; auth=none
- References: <20160519164550 dot GI1611 at redhat dot com> <f60f1609-f457-a1dc-d8e4-55e85c056400 at redhat dot com> <20160519175504 dot GJ1611 at redhat dot com> <20160519200349 dot GK1611 at redhat dot com>
OK.
On Thu, May 19, 2016 at 4:03 PM, Marek Polacek <polacek@redhat.com> wrote:
> On Thu, May 19, 2016 at 07:55:05PM +0200, Marek Polacek wrote:
>> On Thu, May 19, 2016 at 12:55:18PM -0400, Jason Merrill wrote:
>> > Well, constants aren't declarations. Why are we calling dump_decl here?
>>
>> Eh, not sure what I was thinking...
>>
>> We call dump_decl because unify_template_argument_mismatch has %qD:
>> inform (input_location,
>> " template argument %qE does not match %qD", arg, parm);
>> so I suspect we want to print expression ever for PARM:
>>
>> Untested, but I think it should test fine. Ok if testing passes?
>
> Which it did.
>
> Marek