This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/3] function: Factor out make_*logue_seq
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Segher Boessenkool <segher at kernel dot crashing dot org>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 19 May 2016 09:16:26 +0200
- Subject: Re: [PATCH 2/3] function: Factor out make_*logue_seq
- Authentication-results: sourceware.org; auth=none
- References: <213485283eede9da12b217737d95fc8f5c4be442 dot 1463428211 dot git dot segher at kernel dot crashing dot org> <d3064210448ea1d2d7758a3a34e554902333eef2 dot 1463428211 dot git dot segher at kernel dot crashing dot org> <CAMe9rOqs2BsvHNmCgRXDtpOZwxKLotd2xw_4B9oKEsx-qft6Ag at mail dot gmail dot com> <20160518181139 dot GA24289 at gate dot crashing dot org> <CAMe9rOrQmt-avt-NSnRnQxmnL5g6TfJtPUMnY-MLfp_WuwyYCw at mail dot gmail dot com> <20160518183516 dot GB24289 at gate dot crashing dot org> <20160518221325 dot GB8384 at gate dot crashing dot org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, May 18, 2016 at 05:13:25PM -0500, Segher Boessenkool wrote:
> On Wed, May 18, 2016 at 01:35:16PM -0500, Segher Boessenkool wrote:
> > On Wed, May 18, 2016 at 11:20:29AM -0700, H.J. Lu wrote:
> > > >> > * function.c (make_split_prologue_seq, make_prologue_seq,
> > > >> > make_epilogue_seq): New functions, factored out from...
> > > >> > (thread_prologue_and_epilogue_insns): Here.
> > > >>
> > > >> It breaks x86:
> > > >
> > > > Are you sure it is this patch causing it? As noted, it was tested on x86.
> > >
> > > I am pretty sure. How did you test it on x86?
> >
> > "make -k check". I'll test 32-bit now.
>
> Actually, it also fails on 64 bit. It passed my testing because it does
> not fail together with patch 3/3, and does not fail on powerpc at all.
If 3/3 isn't approved soon, can you please revert the problematic commit
until it is if that patch can't work right on its own and needs the other
patch too)? The trunk is in terrible state right now at least on
x86_64/i686-linux, various tests hang forever (e.g. some cleanup-* tests)
and there are hundreds of failures, making it impossible to do proper
regression testing.
Jakub