This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Pekka Jääskeläinen <pekka at parmance dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 18 May 2016 00:20:54 +0000
- Subject: Re: [PATCH 2/4] BRIG (HSAIL) frontend: The FE itself.
- Authentication-results: sourceware.org; auth=none
- References: <573A02A5 dot 1020003 at parmance dot com>
This patch has many improperly formatted diagnostic messages (e.g.
starting with capital letters, ending with '.' or failing to use %q for
quoting). I also note cases where you use %lu as a format for size_t,
which is not correct (you'd need to add pretty-print.c support for %zu
before you could use that, however).
--
Joseph S. Myers
joseph@codesourcery.com