This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch ARM] Fix PR target/53440 - handle generic thunks better for TARGET_32BIT.


On 1 April 2016 at 17:32, Ramana Radhakrishnan
<ramana.radhakrishnan@foss.arm.com> wrote:
> I've had this in my tree for a few months now but never got
> around to submitting it.
>
> This partially fixes PR target/53440 atleast in ARM and
> Thumb2 state. I haven't yet managed to get my head around
> rewriting the Thumb1 support yet.
>
> Tested on armhf with a bootstrap and regression test
> with no regressions.
>

Hi Ramana,

It took me a while to understand why the test was failing on a Thumb1 target
despite the dg-skip directive.
The problem was that dg-do was after dg-skip.

I've checked in the swap, I hope it is "obvious" enough.

Christophe.

> Queued for stage1 now as it isn't technically a regression.
>
> regards
> Ramana
>
>
> <DATE>  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>
>
>         PR target/53440
>         * config/arm/arm.c (arm32_output_mi_thunk): New.
>         (arm_output_mi_thunk): Rename to arm_thumb1_mi_thunk. Rework
>         to split Thumb1 vs TARGET_32BIT functionality.
>         (arm_thumb1_mi_thunk): New.
>
>
>         * g++.dg/inherit/thunk1.C: Support arm / aarch64.

Attachment: skip-thumb1.patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]