This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[Patch V2] Fix SLP PR58135.

From: "Kumar, Venkataramanan" <Venkataramanan dot Kumar at amd dot com>
To: "Richard Beiner (richard dot guenther at gmail dot com)" <richard dot guenther at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Tue, 17 May 2016 11:56:08 +0000
Subject: [Patch V2] Fix SLP PR58135.
Authentication-results: sourceware.org; auth=none
Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=amd.com;
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:23

Hi Richard, 

I created the patch by passing -b option to git. Now the patch is more readable.

As per your suggestion I tried to fix the PR by splitting the SLP store group at vector boundary after the SLP tree is built.

Boot strap PASSED on x86_64.
Checked the patch with check_GNU_style.sh.

The gfortran.dg/pr46519-1.f test now does SLP vectorization. Hence it  generated 2 more vzeroupper.  
As recommended I adjusted the test case by adding -fno-tree-slp-vectorize to make it as expected after loop vectorization.

The following tests are now passing.

------ Snip-----
Tests that now work, but didn't before:

gcc.dg/vect/bb-slp-19.c -flto -ffat-lto-objects  scan-tree-dump-times slp2 "basic block vectorized" 1

gcc.dg/vect/bb-slp-19.c scan-tree-dump-times slp2 "basic block vectorized" 1

New tests that PASS:

gcc.dg/vect/pr58135.c (test for excess errors) gcc.dg/vect/pr58135.c -flto -ffat-lto-objects (test for excess errors)

------ Snip-----

ChangeLog

2016-05-14  Venkataramanan Kumar  <Venkataramanan.kumar@amd.com>
     PR tree-optimization/58135
    * tree-vect-slp.c:  When group size is not multiple of vector size, 
     allow splitting of store group at vector boundary. 

Test suite  ChangeLog
2016-05-14  Venkataramanan Kumar  <Venkataramanan.kumar@amd.com>
    * gcc.dg/vect/bb-slp-19.c:  Remove XFAIL. 
    * gcc.dg/vect/pr58135.c:  Add new.
    * gfortran.dg/pr46519-1.f: Adjust test case.

The attached patch Ok for trunk?

Regards,
Venkat.

Attachment: pr58135.diff.txt
Description: pr58135.diff.txt

Follow-Ups:
- Re: [Patch V2] Fix SLP PR58135.
  - From: Richard Biener

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]