This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Thoughts on memcmp expansion (PR43052)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Fri, 13 May 2016 20:40:50 +0000
- Subject: Re: Thoughts on memcmp expansion (PR43052)
- Authentication-results: sourceware.org; auth=none
- References: <56992541 dot 3090402 at redhat dot com> <CAFiYyc1NX9V9sM=cij75qAGYqGpXGM=1ZioB8cxWNZxsW=uJeQ at mail dot gmail dot com> <5722581B dot 5050402 at redhat dot com> <CAFiYyc3Nvb3Om81Fs6eGpc7oOkvQxJD7Qa_RP-AQh3x_-w-LRw at mail dot gmail dot com> <57274ECF dot 3060909 at redhat dot com> <CAFiYyc3CVOA-wwzeKVkOyKRVOzDS45C3h4PuvACJ1ZWDpRAqwQ at mail dot gmail dot com> <5734B9DF dot 9000505 at redhat dot com> <CAFiYyc1Pq6CBaQ2zrjYW6V4Cz8KGSRzuEmbTN4H9io_-H0y4Gw at mail dot gmail dot com> <5735D120 dot 4070808 at redhat dot com> <CAFiYyc236OVGUPs83CLtq2Q8+O4+7+WUPeD2tn3WnZyA=Gadqg at mail dot gmail dot com> <5735D2F1 dot 20501 at redhat dot com> <alpine dot DEB dot 2 dot 20 dot 1605131338540 dot 28166 at digraph dot polyomino dot org dot uk> <5735DDDB dot 1090808 at redhat dot com>
On Fri, 13 May 2016, Bernd Schmidt wrote:
> Thanks. So, this would seem to suggest that BITS_PER_UNIT in memcmp/memcpy
> expansion is more accurate than a plain 8, although pedantically we might want
> to use CHAR_TYPE_SIZE? Should I adjust my patch to use the latter or leave
> these parts as-is?
I'd say use CHAR_TYPE_SIZE.
--
Joseph S. Myers
joseph@codesourcery.com