This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR driver/69265: add hint for options with misspelled arguments
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: David Malcolm <dmalcolm at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 10 May 2016 22:09:09 +0200
- Subject: Re: [PATCH] PR driver/69265: add hint for options with misspelled arguments
- Authentication-results: sourceware.org; auth=none
- References: <1462839287-3095-1-git-send-email-dmalcolm at redhat dot com>
On Mon, May 09, 2016 at 08:14:47PM -0400, David Malcolm wrote:
> - inform (loc, "valid arguments to %qs are: %s", option->opt_text, s);
> + const char *hint = find_closest_string (arg, &candidates);
> + if (hint)
> + inform (loc, "valid arguments to %qs are: %s; did you mean %qs?",
> + option->opt_text, s, hint);
> + else
> + inform (loc, "valid arguments to %qs are: %s", option->opt_text, s);
> +
btw.. did you consider a format specifier for this ";did you mean %qs"
common stanza?
inform (loc, "valid arguments to %qs are: %s%qhs", x, y, hint);
(let's say) where the specifier would end up empty if hint was NULL.
I don't really like all these odd conditionals on the hints and it also
adds some bloat to have all these duplicate error strings.
Not sure but maybe this would even help translators?
Is there a -Wno-spelling-suggestions to turn the suggestions off
globally, btw?
thanks,