This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>,Ilya Enkovich <enkovich dot gnu at gmail dot com>,gcc-patches at gcc dot gnu dot org
- Date: Tue, 10 May 2016 19:06:02 +0200
- Subject: Re: [PATCH, PR middle-end/70807] Free dominance info in CSE pass
- Authentication-results: sourceware.org; auth=none
- References: <20160510161934 dot GD46462 at msticlxl57 dot ims dot intel dot com> <57321373 dot 9060508 at redhat dot com>
On May 10, 2016 6:59:31 PM GMT+02:00, Bernd Schmidt <bschmidt@redhat.com> wrote:
>On 05/10/2016 06:19 PM, Ilya Enkovich wrote:
>> Curretly CSE may modify CFG and leave invalid dominance info. This
>patch
>> improves track of CFG changes by CSE passes and frees dominance info
>if
>> required. This allows to remove corresponding workaround from STV
>pass.
>>
>> Does it look OK?
>
>Better tracking of cse_cfg_altered seems good regardless. So that's an
>OK for everything but...
>
>> + if (cse_cfg_altered && dom_info_available_p (CDI_DOMINATORS))
>> + free_dominance_info (CDI_DOMINATORS);
>
>I wonder whether it should be the last user of dominance info that
>should be freeing it (maybe it's not just cse that can destroy it?)
>
>Which pass is leaving it around?
Dominators are never freed.
Richard.
>
>Bernd