This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Please include ada-hurd.diff upstream (try2)
- From: Svante Signell <svante dot signell at gmail dot com>
- To: Samuel Thibault <samuel dot thibault at gnu dot org>
- Cc: Eric Botcazou <ebotcazou at adacore dot com>, gcc-patches at gcc dot gnu dot org, Arnaud Charlet <charlet at adacore dot com>, Matthias Klose <doko at debian dot org>
- Date: Wed, 04 May 2016 19:43:27 +0200
- Subject: Re: Please include ada-hurd.diff upstream (try2)
- Authentication-results: sourceware.org; auth=none
- References: <1456875776 dot 5852 dot 194 dot camel at gmail dot com> <20160425095016 dot GB17357 at adacore dot com> <1461580096 dot 8664 dot 262 dot camel at gmail dot com> <3112260 dot f0kR4riLZQ at polaris> <1461744364 dot 8664 dot 335 dot camel at gmail dot com> <20160504152948 dot GF2861 at var dot bordeaux dot inria dot fr> <20160504153407 dot GG2861 at var dot bordeaux dot inria dot fr> <1462380222 dot 2897 dot 39 dot camel at gmail dot com>
- Reply-to: svante dot signell at gmail dot com
On Wed, 2016-05-04 at 18:43 +0200, Svante Signell wrote:
> OnSamuel Thibault, on Wed 04 May 2016 17:29:48 +0200, wrote:
> >
> > > -ÂÂÂ--ÂÂFrom: /usr/include/unistd.h __getpagesize or
> > > getpagesize??
> > > -ÂÂÂfunction Get_Page_Size return int;
> > > +ÂÂÂ--ÂÂFrom: /usr/include/i386-gnu/bits/shm.h __getpagesize or
> > > getpagesize??
> > > +ÂÂÂfunction Get_Page_Size return size_t;
> > > +ÂÂÂfunction Get_Page_Size return Address;
> > >
> > > Why using size_t and Address?ÂÂOther OSes use int, and the
> > > prototype for
> > > getpagesize is returning int.
> > >
> > > Also, don't use the __ versions of the glibc functions, they are
> > > internal aliases, the API is without __.
> > >Â
> >Â
> I thought I did change that, but apparently not. I did such a change,
> but it was probably somewhere else. Please submit your patch upstream
> and to Debian.
No it was not somewhere else. I did change that, see Debian bug
#811063. I even built gcc-6 to make sure everything was OK. And still
it did not get into the updated patch, strange.
May I comment on Debian way of apt-get source gcc-*: Doing that does
not unpack the sources, neither does it apply the patches, you have to
unpack and patch before you can change sources and update patches. Iv'e
patched the sources several times and still find that the updated
patches are not included in the next build. Really confusing.
Thanks!